[RFC][Icedtea-Web]: PR727 Fix deleting of incorrect file when cleaning cache.

[Andrew Su]

----- Original Message -----
> From: "Omair Majid" <omajid at redhat.com>
> To: "Andrew Su" <asu at redhat.com>
> Cc: distro-pkg-dev at openjdk.java.net
> Sent: Thursday, May 26, 2011 6:48:07 PM
> Subject: Re: [RFC][Icedtea-Web]: PR727 Fix deleting of incorrect file when cleaning cache.
> On 05/26/2011 06:04 PM, Andrew Su wrote:
> > Hello,
> >
> > This patch fixes PR727 [1].
> >
> > What was happening before was that when we say we want to keep a
> > file, but it exists again in the list of recently used files, it
> > will
> > add it to remove.
> >
> 
> Hm... why does one entry appear multiple times? Shouldn't we be
> addressing that instead?

This is very odd, since it shouldn't... but when I run javaws as follows, this doesn't happen.

javaws -Xnofork http://www.sweethome3d.com/SweetHome3D.jnlp

> 
> I am a little confused by the current code. The current logic is
> if (delete || keep.contains(...)) {
> ...
> }
> Which I find a little strange (we are treating stuff to delete and
> stuff
> to keep equally?). Your patch certainly makes it look a little more
> sane.
> 
> I see that you are adding a NEWS entry with a different description
> than
> on the bug. Would you mind updating the bug report itself?

ok, updated.

Is it ok for commit to head + 1.1 now?

Cheers,
  Andrew