ping? [RFC] [icedtea-web] reproducer for handling spaces

Omair Majid omajid at redhat.com
Thu Nov 3 12:05:46 PDT 2011


On 11/03/2011 02:33 PM, Jiri Vanek wrote:
> On 11/03/2011 05:35 PM, Omair Majid wrote:
>> On 11/01/2011 12:52 PM, Jiri Vanek wrote:
>>> Hi! This is reproducer for recently fixed PR804 and for new PR811 (based
>>> on Behaviour of javaws when handling spaces).
>>> Currently all local-files requests test are passing (804) ( just one of
>>> them was passing before 804 patch) and all remote (811) requests are
>>> falling.
>>> Some minor changes were necessary to engine. The reproducer itself will
>>> not work without this chnages.
>>>
>>
>> Perhaps we should extract scripts that prepare reproducers from the
>> makefile so we wont need to source NEW_LINE_IFS. What do you think?
>
> On one side I'm not sure how better will be to source extracted scripts
> which prepare reproducers. On the other side, I'm not sure what to
> imagine under "extract them". I imagine separate bash script.... What do
> you yourselves mean?
>

Yes, I meant bash scripts. Sorry if this was not very clear.

I am thinking of something (roughly) like this:
./jnlp-reproducers --compile
./jnlp-reproducers --test-all
./jnlp-reproducers --test simple 'Spaces can be everywhere.jnlp'

Then again, I am not sure if it is really a good idea - especially the 
bit that moves compiling instructions away from the makefile. But I 
think it's an excellent opportunity to sneak in my idea about easily 
being able to run a single test from the command line ;)

As for restoring IFS, you can do simple assignments in the makefile to 
restore IFS:
IFS=$IFS_BACKUP

Thanks,
Omair



More information about the distro-pkg-dev mailing list