ping? [RFC] [icedtea-web] reproducer for handling spaces

[Jiri Vanek]

On 11/04/2011 03:31 PM, Omair Majid wrote:
> On 11/03/2011 04:44 PM, Jiri Vanek wrote:
....
>
>>>> Because it is so easy to run single reproducer from IDE, then i believe
>>>> that the only problem to run it from commandline is correct setting of
>>>> classpath.
>>>>>
>>>>> As for restoring IFS, you can do simple assignments in the makefile to
>>>>> restore IFS:
>>>>
>>>> Actually, you can't. I do not know why, but inside mkefile, the IFS
>>>> variable is different from shell (just space in my case, whether in
>>>> shell contains space,\t and \n). If I'm changing it in "shell", then I
>>>> prefer to restore it by the same way. The line you wrote, was my exactly
>>>> first idea:)
>>>>
>>>
>>> Well if IFS has a different value when running under make, how is that
>>> a problem? As long as you set it back to the old IFS, I would expect
>>> things to work fine.
>>
>> Ok. Unless it cause some catastrophe I will do this as you suggested.
>>
>
> Please let us know how it goes.

It seems it is working as you expected.
The only change is assignment IFS="$$IFS_BACKUP" ; \ instead of restoreIFS() function ( which I still like more ;) )

Thanx
   J
>
> Cheers,
> Omair
>


changelogs:

2011-10-28  Jiri Vanek  <jvanek at redhat.com>

     Added reproducer for PR804 and PR8011
     * tests/jnlp_tests/simple/Spaces can be everywhere/resources/Spaces can be everywhere1.jnlp:
     new jnlp file with space in name and with jar in resources which name does not contain
     spaces
     * tests/jnlp_tests/simple/Spaces can be everywhere/resources/Spaces can be everywhere2.jnlp:
     new jnlp file with space in name and with jar in resources which name contains spaces
     * tests/jnlp_tests/simple/Spaces can be everywhere/resources/SpacesCanBeEverywhere1.jnlp:
     jnlp file without space in name but with jar in resources which name contains spaces
     * tests/jnlp_tests/simple/Spaces can be everywhere/srcs/SpacesCanBeEverywhere.java:
     new file containig simple main method of "Spaces can be everywhere.jar" jar
     * tests/jnlp_tests/simple/Spaces can be everywhere/testcases/SpacesCanBeEverywhereTests.java
     testcase for this reproducer. It is lunching  each of this jnlp once locally from filesystem and
     once remotely from server. Please note that except it's own jar, this reproducer is also
     using simpletest1.jar

2011-10-28  Jiri Vanek  <jvanek at redhat.com>

     Fixed reproducers engine to handle spaces in files and in urls
     * Makefile.am: (stamps/netx-dist-tests-prepare-reproducers.stamp)
     (stamps/netx-dist-tests-sign-some-reproducers.stamp)
     (stamps/netx-dist-tests-compile-testcases.stamp):
     added call to NEW_LINE_IFS to use line breake temporarily as parameter
     separator while loading files from list and correct quoting
     * NEW_LINE_IFS: new file, small separate script used in makefile as inline script
     which backup original IFS variable and then set it to pure new line. It is in
     separate file because it is reused and I do not know another way how to save a new
     line variable in makefile. Restore to original vlaue is handled in Makefile
     *tests/netx/jnlp_testsengine/net/sourceforge/jnlp/ResourcesTest.java:
     (testResourcesExists) filename is encoded to correct URL before requested from server
     * tests/netx/jnlp_testsengine/net/sourceforge/jnlp/ServerAccess.java:
     "-headless" string extracted to variable HEADLES_OPTION
     (executeProcess) and (ThreadedProcess) enhanced for variable dir to specify working
     directory. Backward compatibility kept
     (TinyHttpdImpl) now expects url on requests, so all requests are now decoded by
     java.net.URLDecoder
-------------- next part --------------
A non-text attachment was scrubbed...
Name: SpacesHandlingChangesToEngine2.diff
Type: text/x-patch
Size: 9332 bytes
Desc: not available
Url : http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20111108/ca6eb6b5/SpacesHandlingChangesToEngine2.diff 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: SpacesReproducer.diff
Type: text/x-patch
Size: 18017 bytes
Desc: not available
Url : http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20111108/ca6eb6b5/SpacesReproducer.diff