[icedtea-web] RFC: make getMainClass()'s return value consistent for AppletDesc and ApplicationDesc

[Omair Majid]

Hi,

The attached patch makes the getMainClass() methods of AppletDesc and 
ApplicationDesc return consistent values: class names in the 
dot-separated form ("foo.bar.Baz", not "foo/bar/Baz").

This makes JNLPClassLoader.checkForMain() work correctly with applets 
since it assumes class names are in the right form.

All places that are calling AppletDesc.getMainClass() actually expect 
the same behaviour; they were previously manipulating the result.

I would like to commit this patch to HEAD. Any thoughts or comments?

ChangeLog:
2011-09-28  Omair Majid  <omajid at redhat.com>

     * netx/net/sourceforge/jnlp/AppletDesc.java (getMainClass): Clarify
     the return value in javadoc.
     * netx/net/sourceforge/jnlp/Launcher.java
     (createApplet, createAppletObject): Do not replace '/' with '.'.
     * netx/net/sourceforge/jnlp/PluginBridge.java (PluginBridge):
     Ensure class name is in the dot-separated from.
     * netx/net/sourceforge/jnlp/runtime/JNLPClassLoader.java
     (checkForMain): Ensure that the name is an exact match.

Cheers,
Omair
-------------- next part --------------
A non-text attachment was scrubbed...
Name: icedtea-web-consistent-main-class-name.patch
Type: text/x-patch
Size: 3328 bytes
Desc: not available
Url : http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20110928/f80607e9/icedtea-web-consistent-main-class-name.patch