[icedtea-web] RFC: make getMainClass()'s return value consistent for AppletDesc and ApplicationDesc

[Danesh Dadachanji]

On 28/09/11 03:59 PM, Omair Majid wrote:
> Hi,
>
> The attached patch makes the getMainClass() methods of AppletDesc and
> ApplicationDesc return consistent values: class names in the
> dot-separated form ("foo.bar.Baz", not "foo/bar/Baz").
>
> This makes JNLPClassLoader.checkForMain() work correctly with applets
> since it assumes class names are in the right form.
>
> All places that are calling AppletDesc.getMainClass() actually expect
> the same behaviour; they were previously manipulating the result.
>
> I would like to commit this patch to HEAD. Any thoughts or comments?
>
> ChangeLog:
> 2011-09-28 Omair Majid <omajid at redhat.com>
>
> * netx/net/sourceforge/jnlp/AppletDesc.java (getMainClass): Clarify
> the return value in javadoc.
> * netx/net/sourceforge/jnlp/Launcher.java
> (createApplet, createAppletObject): Do not replace '/' with '.'.
> * netx/net/sourceforge/jnlp/PluginBridge.java (PluginBridge):
> Ensure class name is in the dot-separated from.
> * netx/net/sourceforge/jnlp/runtime/JNLPClassLoader.java
> (checkForMain): Ensure that the name is an exact match.
>
> Cheers,
> Omair

Hi,

Looks good for HEAD!

Regards,
Danesh