[icedtea-web] Broken unit-tests

[Jiri Vanek]

On 04/23/2012 02:44 PM, Omair Majid wrote:
> On 04/23/2012 06:02 AM, Jiri Vanek wrote:
>> Hi!
>> After commit
>> http://icedtea.classpath.org/hg/icedtea-web/rev/f13777a89e0d  the
>> unittests xml result file generation is  broken. It is caused by:
>> ....
>> Passed: net.sourceforge.jnlp.ParserCornerCases.testNestedComments
>> Passed: net.sourceforge.jnlp.ParserCornerCases.testDoubleDashesInComments
>> FAILED:
>> testApplicationImages(net.sourceforge.jnlp.util.ImageResourcesTest) null
>> FAILED: Test mechanism null
>
> Would you mind if I went ahead and pushed this patch?
>
> http://mail.openjdk.java.net/pipermail/distro-pkg-dev/2012-March/017754.html
>
> It fixes the test and thus makes 'make check' work again.

I does??? It looks to me like completely  different issue :)
But the patch should not do any harm, unless :

In time we have been discussing this "awt robot" issue, you have suggested also to "get rid of 
misused xbootclasspath". Isn't that better then add resources.jar?


If you will play with xboothclassapth, please run reproducers test, they can catch a lot:)

J.

btw - The make check is not broken completely - only xml report (and so html report) are not 
generated properly.

>
> Thanks,
> Omair