[icedtea-web] Broken unit-tests

[Omair Majid]

On 04/23/2012 09:26 AM, Jiri Vanek wrote:
> On 04/23/2012 02:44 PM, Omair Majid wrote:
>> On 04/23/2012 06:02 AM, Jiri Vanek wrote:
>>> Hi!
>>> After commit
>>> http://icedtea.classpath.org/hg/icedtea-web/rev/f13777a89e0d  the
>>> unittests xml result file generation is  broken. It is caused by:
>>> ....
>>> Passed: net.sourceforge.jnlp.ParserCornerCases.testNestedComments
>>> Passed:
>>> net.sourceforge.jnlp.ParserCornerCases.testDoubleDashesInComments
>>> FAILED:
>>> testApplicationImages(net.sourceforge.jnlp.util.ImageResourcesTest) null
>>> FAILED: Test mechanism null
>>
>> Would you mind if I went ahead and pushed this patch?
>>
>> http://mail.openjdk.java.net/pipermail/distro-pkg-dev/2012-March/017754.html
>>
>>
>> It fixes the test and thus makes 'make check' work again.
> 
> I does??? It looks to me like completely  different issue :)

Well, something output by that the failing test produces makes the test
runner unhappy (I guess that's what your patch fixes?). The patch I
linked to makes the test pass (which removes that output and makes the
test runner happy).

> But the patch should not do any harm, unless :
> 
> In time we have been discussing this "awt robot" issue, you have
> suggested also to "get rid of misused xbootclasspath". Isn't that better
> then add resources.jar?
> 

Probably. But, unfortunately, I don't have time to work on this at the
moment and I suspect it's not quite simple (there are places in
netx/plugin that make the assumption that the code is part of the
bootclasspath (and loaded by the system classloader)).

Cheers,
Omair