IcedTea6 build failed for b41a73ca64e6 (--enable-nss)

[Mark Wielaard]

On Thu, 2012-08-16 at 19:10 -0400, Andrew Hughes wrote:
>  the autobuilders I've setup, as well as my own builds, pass.

Good. The ones running on builder.classpath.org also with this patchlet.

> Whatever setup is used here (which you didn't include in the original
> e-mail, hence why I'm stabbing in the dark) is not building a complete
> JDK.

I quoted it in the email that I send to report the breakage. And the
autobuilders when they send out email point to the configure logs and
full build, plus all the test results. See
http://builder.wildebeest.org/icedtea/icedtea6/

Also all public autobuilders have their configuration in a mercurial
repo at http://icedtea.classpath.org/hg/buildbot/ so it is very easy to
check.

> From your other e-mail, it sounds like you're using the add-zero
> rule which, as mentioned before, is not supported.

Please stop being childish. It is supported, documented and used. If
not, we wouldn't have found out so quickly that it broke.

> > Aha. Now I understand. That assumes that there is a full build
> > already
> > in place. That isn't always the case when we build zero additionally.
> 
> No, this is a correct assumption.  The IcedTea target is meant to build a full
> JDK and this is what add-nss depends on.

And it worked till your patch broke it. No worries, it is easily fixed.

> This seems to make the build more complicated for absolutely no gain.

It is one simple if statement. If the file doesn't exist, don't try to
patch it. If you have a better fix please do propose it, but this simple
patch solves the regression in the most basic way.

Cheers,

Mark