IcedTea6 build failed for b41a73ca64e6 (--enable-nss)

[Mark Wielaard]

On Thu, 2012-08-16 at 19:45 -0400, Andrew Hughes wrote:
> Sorry if I've been a little blunt on this, but it feels like I've been hounded
> a bit on what is a very low priority issue here.  What's the rush?

I didn't want to hound you. If I made you feel that way sorry. Yes, I
initially asked you to revert your patch till we figured it out. But in
the end I found a very simple patch to fix it. There is also no rush.
But it would be nice if this was fixed since some autobuilders are
currently failing and making people wonder whether or not they have
broken the build because some autobuilders are reporting the build as
broken. So, if we can easily make those autobuilders happy again, that
would make me happy (and others who might get scary emails about build
breakage).

> Looking at it briefly, the add-zero rule is clearly at fault.  If it just
> wants to build HotSpot, it should be calling make hotspot, which would
> just run the OpenJDK part of the build and not the add-x targets designed
> for a full JDK.
> 
> However, my preferred solution would be to just remove these superfluous targets
> altogether as they cause more trouble than they're worth.

I do understand you don't like them. And some of the technical critique
is correct (it would be better if it did only a fake hotspot build
indeed). But currently they are used. And the fix is easy and IMHO not
uglier than what is there. Should we rewrite or change the whole target?
Yes, maybe, but that is not a quick and easy fix for the build breakage
we are seeing (in a configuration I do understand you don't like, but I
do, which is why I provide the fix).

I am currently looking at working better with the icedtea forest. That
seems a good opportunity to revisit some of this build mechanism for
additional runtimes too. I can and will look into cleaning up the rules
and make them play nicer with the rest. But that is more work than just
fixing the regression now. Lets get that in first.

Thanks,

Mark