[RFC][icedtea-web]: Set plugin JVM options in itw-settings

[Adam Domurad]

On 12/04/2012 04:25 PM, Saad Mohammad wrote:
> Hi Adam,
>
> Thanks for all the tips and tricks around C++. Updated patch is attached!
> I'm starting to enjoy C++ as things start working more correctly now. :)

Good to hear :)

> [..snip..]
> +  }
> +
> +  tokenOutput = IcedTeaPluginUtilities::strSplit(output, " \n");
> +
> +  if (!tokenOutput->empty() && *tokenOutput->at(0) =="null")
> +  {
> +    delete tokenOutput->at(0);
> +    tokenOutput->erase(tokenOutput->begin());
> +  }

A comment here about why you're deleting this token would be nice.

Otherwise, I have no further torture to inflict on you :) Looks good to 
me now. If you have tested it to your satisfaction, OK for HEAD.

Thanks,
-Adam

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20121205/bf7382d1/attachment.html