[RFC][icedtea-web]: Set plugin JVM options in itw-settings

[Saad Mohammad]

On 12/05/2012 09:26 AM, Adam Domurad wrote:
> On 12/04/2012 04:25 PM, Saad Mohammad wrote:
>> Hi Adam,
>>
>> Thanks for all the tips and tricks around C++. Updated patch is attached!
>> I'm starting to enjoy C++ as things start working more correctly now. :)
> 
> Good to hear :)
> 
>> [..snip..]
>> +  }
>> +
>> +  tokenOutput = IcedTeaPluginUtilities::strSplit(output, " \n");
>> +
>> +  if (!tokenOutput->empty() && *tokenOutput->at(0) =="null")
>> +  {
>> +    delete tokenOutput->at(0);
>> +    tokenOutput->erase(tokenOutput->begin());
>> +  }
> 
> A comment here about why you're deleting this token would be nice.
> 
> Otherwise, I have no further torture to inflict on you :) Looks good to me now.
> If you have tested it to your satisfaction, OK for HEAD.
> 
> Thanks,
> -Adam
> 
> 

Thanks again for all the feedback!
Pushed: <http://icedtea.classpath.org/hg/icedtea-web/rev/141cb4463629>

-- 
Cheers,
Saad Mohammad