Icedtea7-forest - busted jdk_generic_profile.sh JPEG_LIBS logic...

[Deepak Bhole]

* Chris Phillips <chphilli at redhat.com> [2012-02-14 12:43]:
> Hi
> Just a heads-up regarding building from icedtea7-forest "manually":
> 
>  jdk/make/jdk_generic_profile.sh:
> 
>    420  # Export variables for system jpeg
>    421  # JPEG_CFLAGS and JPEG_LIBS tell the compiler how to compile and
>    422  # link against libjpeg
>    423  if [ "${JPEG_LIBS}" = "" ] ; then
>    424      ZLIB_LIBS="-ljpeg"
>    425  fi
>    426  export JPEG_LIBS
> 
> Probably wants:
>    424      JPEG_LIBS="-ljpeg"
> 
> (this is all changed in current jdk, so don't know if its worth fixing)
> 

Ugh, this would be my bad. I spotted this a while ago and fixed it in
Fedora:

http://pkgs.fedoraproject.org/gitweb/?p=java-1.7.0-openjdk.git;a=blob;f=java-1.7.0-openjdk-system-zlib.patch;h=627ebd11b96793d7b000d833c41088c2e86b1ebc;hb=308630c6e238f591ad90a92fed0702986856c418

I started a build and planned to propose after verifying that all was
OK.. and then obviously forgot :/

I will propose it upstream.

Deepak

> Chris
> 
> -- 
> --
> --     Woda: "Java: write once, debug anywhere" Hong Zhang
>                      http://thehenrys.ca
>  | Chris Phillips @ T.O. Red Hat OpenJDK JVM Engineer,            |
>  | mailto:ChPhilli at RedHat.Com                  (416)483-3768      |
>  | http://LGonQn.Org/www/Chris.Phillips  cell: (416)505-3610      |
>  "EPIC stands for Expects Perfectly Intuitive Compilers" P. Bannon
>                   http://www.hazmatmodine.com
>  NOTICE:
>  This email message is for the sole use of the intended recipient(s)
>  and may contain confidential and privileged information.  Any
>  unauthorized review, use, disclosure or distribution is prohibited.
>  If you are not the intended recipient, please contact the sender by
>  reply email and destroy all copies of the original message.
>                    "blah blah blah - Ginger!"
> --
> --
> 
>