Icedtea7-forest - busted jdk_generic_profile.sh JPEG_LIBS logic...

[Andrew Hughes]

----- Original Message -----
> * Chris Phillips <chphilli at redhat.com> [2012-02-14 12:43]:
> > Hi
> > Just a heads-up regarding building from icedtea7-forest "manually":
> > 
> >  jdk/make/jdk_generic_profile.sh:
> > 
> >    420  # Export variables for system jpeg
> >    421  # JPEG_CFLAGS and JPEG_LIBS tell the compiler how to
> >    compile and
> >    422  # link against libjpeg
> >    423  if [ "${JPEG_LIBS}" = "" ] ; then
> >    424      ZLIB_LIBS="-ljpeg"
> >    425  fi
> >    426  export JPEG_LIBS
> > 
> > Probably wants:
> >    424      JPEG_LIBS="-ljpeg"
> > 
> > (this is all changed in current jdk, so don't know if its worth
> > fixing)
> > 
> 
> Ugh, this would be my bad. I spotted this a while ago and fixed it in
> Fedora:
> 
> http://pkgs.fedoraproject.org/gitweb/?p=java-1.7.0-openjdk.git;a=blob;f=java-1.7.0-openjdk-system-zlib.patch;h=627ebd11b96793d7b000d833c41088c2e86b1ebc;hb=308630c6e238f591ad90a92fed0702986856c418
> 
> I started a build and planned to propose after verifying that all was
> OK.. and then obviously forgot :/
> 
> I will propose it upstream.
> 
> Deepak
> 

What do you need to propose?  This could have just been committed.  I thought you had ages ago.

Neither I nor IcedTea run jdk_generic_profile.sh so it doesn't get tested.  As I've said before,
we need more people using and testing 7.
-- 
Andrew :)

Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

PGP Key: 248BDC07 (https://keys.indymedia.org/)
Fingerprint = EC5A 1F5E C0AD 1D15 8F1F  8F91 3B96 A578 248B DC07