Reviewer needed: fixed typos in JDK7 forest (ScriptEngineManager class)

Andrew Hughes ahughes at redhat.com
Mon Mar 5 12:14:50 PST 2012


----- Original Message -----
> Andrew Hughes wrote:
> > ----- Original Message -----
> >> Andrew Hughes wrote:
> >>> ----- Original Message -----
> >>>> ----- Original Message -----
> >>>>> Hi,
> >>>>>
> >>>>> I'd like to fix JavaDoc typos in a class ScriptEngineManager.
> >>>>> Patch
> >>>>> applicable
> >>>>> to jdk7 forest is stored in an attachment.
> >>>>>
> >>>>> Can anybody please review this change?
> >>>>>
> >>>>> Thank you in advance.
> >>>>>
> >>>>> Cheers,
> >>>>> Pavel
> >>>>>
> >>>>> (fix for upstream will follow).
> >>>>>
> >>>>>
> >>>>>
> >>>>> [Text Documents:hg_diff.patch]
> >>>>>
> >>>> Such a change to public javax.* classes needs to go upstream
> >>>> first.
> >>>>  Although
> >>>> the changes are minor, this alters the API specification.
> >>>> --
> >>>> Andrew :)
> >>>>
> >>>> Free Java Software Engineer
> >>>> Red Hat, Inc. (http://www.redhat.com)
> >>>>
> >>>> PGP Key: 248BDC07 (https://keys.indymedia.org/)
> >>>> Fingerprint = EC5A 1F5E C0AD 1D15 8F1F  8F91 3B96 A578 248B DC07
> >>>>
> >>>>
> >>> I see this was reviewed and pushed to 8:
> >>>
> >>> http://mail.openjdk.java.net/pipermail/core-libs-dev/2012-February/009380.html
> >>> http://mail.openjdk.java.net/pipermail/core-libs-dev/2012-March/009422.html
> >>>
> >>> Let's see if it makes it to 7u.  If it does, we can add it to
> >>> IcedTea7 too, ahead of u6.
> >> FYI: now this change is in 7u(6) too.
> >>
> >> Pavel
> >>
> > 
> > What was the reason for not posting to u4?  This doesn't seem to be
> > have been discussed publicly.
> > If it has, please point me to a link.
> 
> I received personal mail from Edvard Wendeling saying "JDK 7u4 is now
> ramping down and the inflow of bug fixes is more
> restricted...."
> 
> Given this patch just changes JavaDoc and does not fix any real bug,
> I personally don't feel
> the need to hurry and push it to u4.
> 

Ok.  I think this is fine for the forest, which will put it in IcedTea's ~u4 anyway.
-- 
Andrew :)

Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

PGP Key: 248BDC07 (https://keys.indymedia.org/)
Fingerprint = EC5A 1F5E C0AD 1D15 8F1F  8F91 3B96 A578 248B DC07




More information about the distro-pkg-dev mailing list