[rfc][icedtea-web] reprducers for main class specified in manifest instead in application descriptor

Pavel Tisnovsky ptisnovs at redhat.com
Thu Mar 8 06:39:42 PST 2012


Jiri Vanek wrote:
> On 03/07/2012 05:48 PM, Pavel Tisnovsky wrote:
>> Hi Jiri,
>>
> Thanx for review!
>> it looks good. I have two questions:
>>
>> 1) in both files MANIFEST.MF it seems that DOS EOLs are used (I can
>> see ^M on the end of the lines). Did you use DOS
>> files deliberately?
> fixed!
>>
>> 2) probably another test case should be included: two jars, both with
>> manifests, both set as main (it should fail AFAIK)
> added(and two more similar)!
> however it is passing - first in-manifest mainclass is launched.
> On the other side when two jars with main mark are lunched via main
> class in application-desc, then invalid xml exception is thrown. I think
> both can be considered as correct.

Great. I looks good (although it would be IMHO better to show error dialog in such cases, but it's not part of your
tests ;-)
Pavel


>>
>> Cheers,
>> Pavel
>>
> 
> Best regards, J
> 




More information about the distro-pkg-dev mailing list