[rfc][icedtea-web] reprducers for main class specified in manifest instead in application descriptor
Jiri Vanek
jvanek at redhat.com
Thu Mar 8 02:51:28 PST 2012
On 03/07/2012 05:48 PM, Pavel Tisnovsky wrote:
> Hi Jiri,
>
Thanx for review!
> it looks good. I have two questions:
>
> 1) in both files MANIFEST.MF it seems that DOS EOLs are used (I can see ^M on the end of the lines). Did you use DOS
> files deliberately?
fixed!
>
> 2) probably another test case should be included: two jars, both with manifests, both set as main (it should fail AFAIK)
added(and two more similar)!
however it is passing - first in-manifest mainclass is launched.
On the other side when two jars with main mark are lunched via main class in application-desc, then invalid xml exception is thrown. I think both can be considered as correct.
>
> Cheers,
> Pavel
>
Best regards, J
-------------- next part --------------
A non-text attachment was scrubbed...
Name: MainClassInManifestTest2.diff
Type: text/x-patch
Size: 41131 bytes
Desc: not available
Url : http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20120308/1e3603c3/MainClassInManifestTest2.diff
More information about the distro-pkg-dev
mailing list