[RFC][icedtea-web] Plugin doesn't halt when required elements from JNLP files are missing.

[Jiri Vanek]

On 03/14/2012 09:08 PM, Danesh Dadachanji wrote:
>
> On 14/03/12 08:40 AM, Jiri Vanek wrote:
>> Yap. I think this can go in now with minor fix - In changelog you have
>> mentioned + *
>> tests/jnlp_tests/simple/InformationTitleVendorParser/srcs/TitleVendorParser.java,
>> but this one is not going in (as you are using simpletest1 and the file
>> is not present in patch), Ensure also if this
>> InformationTitleVendorParser/srcs dir is really empty in your testing
>> builds (if isn't ensure all is working when emptied).
>> btw - spaces in changelog instead of tabs, although I suspect email
>> clients to did so, please check before push.
>
> Done, I have removed the srcs dir too.
>
>> Thanx for test and after minor issue being fixed, please push.
>
> I actually noticed one more issue, after Omair's fix[1] for printing errors to terminal, it no longer prints the exception. I've changed the code to match part of the output. Here's what would be printed for a JNLP without <information>:
>
> netx: Read Error: Could not read or parse the JNLP file. (No information section defined)
>
>
> Here are the changes between this attached patch and the previous one:
>
> - String s2 = "(?s).*net.sourceforge.jnlp.ParseException.{0,5}" + exceptionMessage + "(?s).*";
> + // Looking for "Could not read or parse the JNLP file. (${DESCRIPTION})"
> + String s2 = "(?s).*Could not read or parse the JNLP file.{0,5}" + exceptionMessage + "(?s).*";
>
>
> Can you just clarify this patch is okay for HEAD too?
>
> ChangeLog
> +2012-03-14 Danesh Dadachanji <ddadacha at redhat.com>
> +
> + Applications using JNLP files without a title or vendor section
> + still run, despite them being required elements.
> + * netx/net/sourceforge/jnlp/Parser.java:
> + (getInformationDesc): If title or vendor are not found in info,
> + a new ParseException is thrown.
> + * netx/net/sourceforge/jnlp/resources/Messages.properties:
> + Added PNoTitleElement and PNoVendorElement
> + * tests/jnlp_tests/simple/InformationTitleVendorParser/resources/InformationParser.jnlp,
> + * tests/jnlp_tests/simple/InformationTitleVendorParser/resources/TitleParser.jnlp,
> + * tests/jnlp_tests/simple/InformationTitleVendorParser/resources/TitleVendorParser.jnlp,
> + * tests/jnlp_tests/simple/InformationTitleVendorParser/resources/VendorParser.jnlp,
> + * tests/jnlp_tests/simple/InformationTitleVendorParser/testcases/TitleVendorParserTest.java:
> + New test that runs JNLPs in a combination of missing information, title
> + and vendor tags, checking for the appropriate exceptions.
> +
>
> Cheers,
> Danesh

Approved second times;)

J.