[RFC][icedtea-web] Plugin doesn't halt when required elements from JNLP files are missing.

Omair Majid omajid at redhat.com
Fri Mar 16 16:35:36 PDT 2012

On 03/14/2012 04:08 PM, Danesh Dadachanji wrote:
> +    * netx/net/sourceforge/jnlp/Parser.java:
> +    (getInformationDesc): If title or vendor are not found in info,
> +    a new ParseException is thrown.

There is something wrong here. Many unit tests contain snippets of jnlp
files that do not contain title or vendor tags. Those unit tests are
(mostly) still passing (by this, I mean a simple parse operation on them
succeeds). I see about 1 new failure where I was expecting tons.

Did I mention I prefer unit tests rather than integration tests for
checking corner cases? :)


More information about the distro-pkg-dev mailing list