[RFC][icedtea-web] Plugin doesn't halt when required elements from JNLP files are missing.

Jiri Vanek jvanek at redhat.com
Sun Mar 18 23:38:09 PDT 2012

On 03/17/2012 12:35 AM, Omair Majid wrote:
> On 03/14/2012 04:08 PM, Danesh Dadachanji wrote:
>> +    * netx/net/sourceforge/jnlp/Parser.java:
>> +    (getInformationDesc): If title or vendor are not found in info,
>> +    a new ParseException is thrown.
> There is something wrong here. Many unit tests contain snippets of jnlp
> files that do not contain title or vendor tags. Those unit tests are
> (mostly) still passing (by this, I mean a simple parse operation on them
> succeeds). I see about 1 new failure where I was expecting tons.

As far as I know Danesh have fixed all the information elements across testcases.
> Did I mention I prefer unit tests rather than integration tests for
> checking corner cases? :)

Yap. This give sense. The fault of directing this to reproducers run to my head :(

> Cheers,
> Omair

More information about the distro-pkg-dev mailing list