[icedtea-web] RFC: PR898: signed applications with big jnlp-file doesn't start

[Jiri Vanek]

On 03/22/2012 02:11 PM, Jiri Vanek wrote:
> On 03/22/2012 01:58 PM, Omair Majid wrote:
>> On 03/22/2012 08:42 AM, Jiri Vanek wrote:
>>> On 03/22/2012 10:38 AM, Jiri Vanek wrote:
>>> Just two more minor nitpicks
>>>
>>> Can you add bug number/link to reproducer comment and to changelog?
>>>
>>
>> Done for ChangeLog/NEWS. I would rather not add bug numbers to the
>> codebase/test case though - I feel that the testcase stands on its own
>> and adding bug numbers doesnt really add new value. It is stored in the
>> mercurial history and changelog for those who do want to look it up.
>
> Then you will be enemy of #bug annotation? :)
>>
>>>> If you are ok now with default utf-8 encoding, I'm for, and if you
>>>> will consider the encoding
>>>> reading and then re-encode if necessary, then it can be as separate
>>>> patch.
>>>>
>>
>> I would rather not mess with encoding in this patch. It's not a
>> regression, right? If it does cause problems later, I (or someone else)
>> will, of course, fix it.
>
> hmm.. But you are adding byte <-> string transformations unless I'm very wrong. Aren't you?
>
> Maybe to set plain ASCII can be solution?

Ah now I see that you are right. It was "wrong" even in previous Implementation. I'm now ok with the patch And I will try to find an reproducer for this approach to fail.

Thanx for patience
J.
>>
>> The only change between this patch and the one I posted before is the
>> NEWS/ChangeLog update.
>>
>> Okay for HEAD? 1.2?
>>
>> Thanks,
>> Omair
>