[rfc] [icedtea-web] make links

Andrew Hughes ahughes at redhat.com
Fri May 11 05:26:21 PDT 2012



----- Original Message -----
> On 05/11/2012 01:25 PM, Andrew Hughes wrote:
> > ----- Original Message -----
> >> Hi Andrew, I just realized that I forgot to send opera;firefox...
> >> string to code coverage. This
> >> patch is add-one-line boosted makeLInks3 i sent few hours ago.
> >> Thanx
> >> and sorry
> >> J.
> >>
> >
> > There are still two issues here:
> >
> > 1.  Simple typo: "backuped" should be "backed up"

> Sure. will be fixed

:-)

> > 2.  It's still expecting the plugin to be in
> > $(DESTDIR)$(libdir)/$(BUILT_PLUGIN_LIBRARY),
> > the final install location.  It needs to link to to the copy in the
> > build directory.

> Hmm... I still believe I'm doing the correct thing. All Reproducers
> tests are run against $(DESTDIR).

Then they are wrong too.   I should be able to check it works before I
commit to installing it on my system.

> >
> Thanx for review!
> 
> J.
> 
> 

-- 
Andrew :)

Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

PGP Key: 248BDC07 (https://keys.indymedia.org/)
Fingerprint = EC5A 1F5E C0AD 1D15 8F1F  8F91 3B96 A578 248B DC07




More information about the distro-pkg-dev mailing list