[rfc] [icedtea-web] make links

[Jiri Vanek]

On 05/11/2012 02:26 PM, Andrew Hughes wrote:
>
> ----- Original Message -----
>> >  On 05/11/2012 01:25 PM, Andrew Hughes wrote:
>>> >  >  ----- Original Message -----
>>>> >  >>  Hi Andrew, I just realized that I forgot to send opera;firefox...
>>>> >  >>  string to code coverage. This
>>>> >  >>  patch is add-one-line boosted makeLInks3 i sent few hours ago.
>>>> >  >>  Thanx
>>>> >  >>  and sorry
>>>> >  >>  J.
>>>> >  >>
>>> >  >
>>> >  >  There are still two issues here:
>>> >  >
>>> >  >  1.  Simple typo: "backuped" should be "backed up"
>> >  Sure. will be fixed
  :-O F I X E D O:-)
>
>>> >  >  2.  It's still expecting the plugin to be in
>>> >  >  $(DESTDIR)$(libdir)/$(BUILT_PLUGIN_LIBRARY),
>>> >  >  the final install location.  It needs to link to to the copy in the
>>> >  >  build directory.
>> >  Hmm... I still believe I'm doing the correct thing. All Reproducers
>> >  tests are run against $(DESTDIR).
> Then they are wrong too.   I should be able to check it works before I
> commit to installing it on my system.

Well they are reproducers, they expect to be run on installed stuff.

ok now?
>
>>> >  >
>> >  Thanx for review!
>> >

>

-------------- next part --------------
A non-text attachment was scrubbed...
Name: makeLinks5.diff
Type: text/x-patch
Size: 10056 bytes
Desc: not available
Url : http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20120511/05bbc0c6/makeLinks5.diff