[RFC][icedtea-web] Fix usage of == -> .equals for various String comparisons

[Deepak Bhole]

* Adam Domurad <adomurad at redhat.com> [2012-05-15 16:17]:
> Hey, first try at a commit. 
> 
> I went through the source of IcedTeaWeb with FindBugs and went over all reported cases of == being used to compare String's. Some usage cases were valid (eg, .equals eventually called, magic String value). I noted one such usage case. The others were changed to .equals calls.
> 

Hi Adam,

Thanks! Few minor grammar issues and one technical issue:

> Changelog entry:
> 2012-05-15  Adam Domurad  <adomurad at redhat.com>
> 
> 	Fixed uses of == to compare String objects to .equals where appropriate
> 	noted a non-obvious use of == to compare a 'magic' String reference.

Period after appropriate, capital N for noted.

> 	* netx/net/sourceforge/jnlp/JNLPFile.java: and

The first entry should specify what is being done with the rest saying
something like "Same." rather than the specification being for the last
entry. Also, please capitalize the a in "added" below.

> 	* plugin/icedteanp/java/sun/applet/GetMemberPluginCallRequest.java: and
> 	* plugin/icedteanp/java/sun/applet/PluginCallRequestFactory.java:
> 	changed calls that compare String contents from == to .equals
> 	* netx/net/sourceforge/jnlp/Version.java: added comment explaining why
> 	== was used vs .equals

> diff --git a/plugin/icedteanp/java/sun/applet/GetMemberPluginCallRequest.java b/plugin/icedteanp/java/sun/applet/GetMemberPluginCallRequest.java
> --- a/plugin/icedteanp/java/sun/applet/GetMemberPluginCallRequest.java
> +++ b/plugin/icedteanp/java/sun/applet/GetMemberPluginCallRequest.java
> @@ -50,7 +50,7 @@ public class GetMemberPluginCallRequest 
>          String[] args = message.split(" ");
>          // FIXME: Is it even possible to distinguish between null and void
>          // here?
> -        if (args[3] != "null" && args[3] != "void")
> +        if (args[3].equals("null") && args[3].equals("void"))


This changes the logic. Should be:

	if (!args[3].equals("null") && !args[3].equals("void")) ...


Rest looks good. After the fixing the above, OK for HEAD/1.1/1.2

Cheers,
Deepak