[RFC][icedtea-web] Fix usage of == -> .equals for various String comparisons

[Pavel Tisnovsky]

Adam Domurad wrote:
> Hey, first try at a commit. 
> 
> I went through the source of IcedTeaWeb with FindBugs and went over all reported cases of == being used to compare String's. Some usage cases were valid (eg, .equals eventually called, magic String value). I noted one such usage case. The others were changed to .equals calls.
> 
> Changelog entry:
> 2012-05-15  Adam Domurad  <adomurad at redhat.com>
> 
> 	Fixed uses of == to compare String objects to .equals where appropriate
> 	noted a non-obvious use of == to compare a 'magic' String reference.
> 	* netx/net/sourceforge/jnlp/JNLPFile.java: and
> 	* plugin/icedteanp/java/sun/applet/GetMemberPluginCallRequest.java: and
> 	* plugin/icedteanp/java/sun/applet/PluginCallRequestFactory.java:
> 	changed calls that compare String contents from == to .equals
> 	* netx/net/sourceforge/jnlp/Version.java: added comment explaining why
> 	== was used vs .equals
> 

Hi Adam,

I'm a bit worried with following changes:

-        if (id == "member") {
+        if (id.equals("member")) {
             return new GetMemberPluginCallRequest(message, reference);
-        } else if (id == "void") {
+        } else if (id.equals("void")) {
             return new VoidPluginCallRequest(message, reference);
-        } else if (id == "window") {
+        } else if (id.equals("window")) {
             return new GetWindowPluginCallRequest(message, reference);
-        } else if (id == "proxyinfo") {
+        } else if (id.equals("proxyinfo")) {
             return new PluginProxyInfoRequest(message, reference);
-        } else if (id == "cookieinfo") {
+        } else if (id.equals("cookieinfo")) {

It could change the runtime behaviour of the application in case the "id" is null.
In previous version the NPE is not thrown, but with your changes it could occur.
IMHO it would be better to change the first and second item for equals, like this:
if ("member".equals(id)) ....

Cheers,
Pavel