[RFC][icedtea-web] Fix usage of == -> .equals for various String	comparisons
    Adam Domurad 
    adomurad at redhat.com
       
    Wed May 16 09:08:46 PDT 2012
    
    
  
Thanks Jiri, Deepak, Pavel for reviewing my patch!
I have fixed the issues previously state, except for the constant extraction suggestion. 
Here are the updated Changelog and patch file.
Changelog:
2012-05-16  Adam Domurad  <adomurad at redhat.com>
	Fixed uses of == to compare String objects to .equals where 
	appropriate.
	Noted a non-obvious use of == to compare a 'magic' String reference.
	* netx/net/sourceforge/jnlp/JNLPFile.java:
	Changed calls that compare String contents from == to .equals
	* plugin/icedteanp/java/sun/applet/GetMemberPluginCallRequest.java: 
	Same
	* plugin/icedteanp/java/sun/applet/PluginCallRequestFactory.java:
	Same
	* netx/net/sourceforge/jnlp/Version.java: Added comment explaining why
	== was used vs .equals
-------------- next part --------------
A non-text attachment was scrubbed...
Name: findbugs-assisted-string-equals-fix.patch
Type: text/x-patch
Size: 4515 bytes
Desc: not available
Url : http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20120516/0a1a8bb8/findbugs-assisted-string-equals-fix.patch 
    
    
More information about the distro-pkg-dev
mailing list