[RFC][icedtea-web] Fix usage of == -> .equals for various String comparisons

[Jiri Vanek]

On 05/16/2012 06:08 PM, Adam Domurad wrote:
> Thanks Jiri, Deepak, Pavel for reviewing my patch!
>
> I have fixed the issues previously state, except for the constant extraction suggestion.

Yah? :) I hope to see it in close future! O:)

>
> Here are the updated Changelog and patch file.
>
> Changelog:
> 2012-05-16  Adam Domurad<adomurad at redhat.com>
>
> 	Fixed uses of == to compare String objects to .equals where
> 	appropriate.
> 	Noted a non-obvious use of == to compare a 'magic' String reference.
> 	* netx/net/sourceforge/jnlp/JNLPFile.java:
> 	Changed calls that compare String contents from == to .equals
> 	* plugin/icedteanp/java/sun/applet/GetMemberPluginCallRequest.java:
> 	Same
> 	* plugin/icedteanp/java/sun/applet/PluginCallRequestFactory.java:
> 	Same
> 	* netx/net/sourceforge/jnlp/Version.java: Added comment explaining why
> 	== was used vs .equals

Looks ok from my point of view. I'm ok with head and in some time to be backported to branches as 
Deepak suggested.


Just one nitpick for any time - http://icedtea.classpath.org/wiki/IcedTea-Web#Testing_IcedTea-Web 
(and http://icedtea.classpath.org/wiki/Reproducers) - please, before any push try to run:
make
make check
make install
make run-netx-dist-tests

sequence and observe html reports (how they differ with your change set and without).  They are 
really useful for catching regressions. And it is better to got them before push. Also a tests is 
mostly required for any change (deficiently not for this one :) )


Thanx a lot for patch and best regards from CZ!

    J.