Thermostat 0.2 Released!

[Andrew Dinn]

Hi Thermostatters,

I tried building thermostat 0.2 (or rather the latest hg clone of the
repo) yesterday and got an error from surefire when executing the agent
tests. Details included below.

regards,


Andrew Dinn
-----------

Here is the maven output
----- 8< -------- 8< -------- 8< -------- 8< -------- 8< ---
. . .
Running com.redhat.thermostat.agent.config.AgentOptionParserTest
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.035 sec
Running com.redhat.thermostat.backend.system.DistributionInformationTest
Tests run: 2, Failures: 2, Errors: 0, Skipped: 0, Time elapsed: 0.011
sec <<< FAILURE!

Results :

Failed tests:
testName(com.redhat.thermostat.backend.system.DistributionInformationTest)

testVersion(com.redhat.thermostat.backend.system.DistributionInformationTest)

Tests run: 85, Failures: 2, Errors: 0, Skipped: 0

[INFO]
------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Thermostat ........................................ SUCCESS [6.154s]
[INFO] Thermostat Common ................................. SUCCESS [17.301s]
[INFO] Thermostat Agent .................................. FAILURE [4.588s]
[INFO] Thermostat Client ................................. SKIPPED
[INFO] Thermostat Client Core ............................ SKIPPED
[INFO] Thermostat Client Launcher ........................ SKIPPED
[INFO] Thermostat Client VmClassStat plugin .............. SKIPPED
[INFO] Thermostat Example Client bundle .................. SKIPPED
[INFO] Thermostat Process handler plugin ................. SKIPPED
[INFO] Thermostat Client Terminate VM plugin ............. SKIPPED
[INFO] Thermostat Tools .................................. SKIPPED
[INFO] Thermostat Distribution ........................... SKIPPED
[INFO]
------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO]
------------------------------------------------------------------------
[INFO] Total time: 28.947s
[INFO] Finished at: Fri May 18 09:50:44 BST 2012
[INFO] Final Memory: 31M/199M
[INFO]
------------------------------------------------------------------------
[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-surefire-plugin:2.12:test (default-test)
on project thermostat-agent: There are test failures.
----- 8< -------- 8< -------- 8< -------- 8< -------- 8< ---

The surefire .txt output for the offending test includes this

----- 8< -------- 8< -------- 8< -------- 8< -------- 8< ---
-------------------------------------------------------------------------------
Test set: com.redhat.thermostat.backend.system.DistributionInformationTest
-------------------------------------------------------------------------------
Tests run: 2, Failures: 2, Errors: 0, Skipped: 0, Time elapsed: 0.011
sec <<< FAILURE!
testName(com.redhat.thermostat.backend.system.DistributionInformationTest)
 Time elapsed: 0.005 sec  <<< FAILURE!
java.lang.AssertionError
	at org.junit.Assert.fail(Assert.java:92)
	at org.junit.Assert.assertTrue(Assert.java:43)
	at org.junit.Assert.assertFalse(Assert.java:68)
	at org.junit.Assert.assertFalse(Assert.java:79)
	at
com.redhat.thermostat.backend.system.DistributionInformationTest.testName(DistributionInformationTest.java:55)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
. . .
----- 8< -------- 8< -------- 8< -------- 8< -------- 8< ---

The corresponding code is

----- 8< -------- 8< -------- 8< -------- 8< -------- 8< ---
   . . .
48     public void testName() {
49         if (TestUtils.isLinux()) {
50             DistributionInformation info = DistributionInformation.get();
51             String name = info.getName();
52             assertNotNull(name);
53             assertTrue(name.length() > 0);
54             assertFalse(name.startsWith(":"));
55
assertFalse(name.equals(DistributionInformation.UNKNOWN_NAME));
   . . .
----- 8< -------- 8< -------- 8< -------- 8< -------- 8< ---