[RFC][icedtea-web][rhino] added tests for corner cases of dateRange and enabled testWeekdayRange

Omair Majid omajid at redhat.com
Tue May 22 10:48:22 PDT 2012


On 11/10/2011 06:12 AM, Jiri Vanek wrote:
> Attached is patch with fixed indentation

Well, turns out that this isn't quite true :(

> -    // note: watch out for wrapping around of dates. date ranges, like
> -    // month=9 to month=8, wrap around and cover the entire year. this
> -    // makes everything more interesting
> +    function isDateInRange() {

I completely missed that this makes isDateInRange a top-level function.
I intentionally wanted to avoid this; this script now exposes this
(unexpected) function to all the proxy auto config scripts. I can
imagine all sorts of name clashes if a script accidentally defines a
function with the same name. Can we fix this somehow while still keeping
the testing benefits?

Thanks,
Omair



More information about the distro-pkg-dev mailing list