[RFC][icedtea-web][rhino] added tests for corner cases of dateRange and enabled testWeekdayRange

[Jiri Vanek]

On 05/22/2012 07:48 PM, Omair Majid wrote:
> On 11/10/2011 06:12 AM, Jiri Vanek wrote:
>> Attached is patch with fixed indentation
>
> Well, turns out that this isn't quite true :(
>
>> -    // note: watch out for wrapping around of dates. date ranges, like
>> -    // month=9 to month=8, wrap around and cover the entire year. this
>> -    // makes everything more interesting
>> +    function isDateInRange() {
>
> I completely missed that this makes isDateInRange a top-level function.
> I intentionally wanted to avoid this; this script now exposes this
> (unexpected) function to all the proxy auto config scripts. I can
> imagine all sorts of name clashes if a script accidentally defines a
> function with the same name. Can we fix this somehow while still keeping
> the testing benefits?

Well javascript private-members is painful theme. Just google around and you will get scared. What 
just about to rename it?
I will need some nasty refactoring and prototyping which have its disadvantages.

isDateInRange -> diuaseOUIUHroigjodHPffg484gfjfg ? :)

or better
isDateInRange - > isDateInRange_internallForIcedTeaWebTesting ?
>
> Thanks,
> Omair