[icedtea-web][rfc] Update to AppletTakesLastParam reproducer

Omair Majid omajid at redhat.com
Tue Oct 16 13:05:34 PDT 2012


On 10/12/2012 12:05 PM, Adam Domurad wrote:
> This is a minor update to AppletTakesLastParam (no bug report associated).
> This will cause the reproducer to finish more quickly (as well as having
> a bit of code cleanup).

The change in sleep() looks fine to me.

> +        System.out.println("*** APPLET FINISHED ***");
> +
> +        // To quickly close JNLP applet 
> +        //(NB: System.exit must be in separate thread for applets)
> +        new Thread() {
> +            @Override
> +            public void run() {
> +                System.exit(0);

The comment is not right. Applet's cant call System.exit(), not in the
applet thread and not in another thread. If they could, a random applet
could take down the entire JVM, killing all other applets in the browser.

Please fix the comment before you push.

Cheers,
Omair

-- 
PGP Key: 66484681 (http://pgp.mit.edu/)
Fingerprint = F072 555B 0A17 3957 4E95  0056 F286 F14F 6648 4681



More information about the distro-pkg-dev mailing list