[rfc][icedtea-web] Fix most cases of error splash not appearing
Adam Domurad
adomurad at redhat.com
Tue Apr 30 12:12:40 PDT 2013
On 04/30/2013 10:53 AM, Jiri Vanek wrote:
> On 04/30/2013 04:03 PM, Adam Domurad wrote:
>> On 04/30/2013 10:01 AM, Jiri Vanek wrote:
>>> On 04/29/2013 11:00 PM, Adam Domurad wrote:
>>>> Hi all. I am disappointed a bit that I do not know exactly *why*
>>>> this patch has the effect that it
>>>> does, beyond removing a difference between the error path (ie,
>>>> LaunchException occurs) and the
>>>> normal code-path.
>>>> With this patch applied I always see the error splash on my
>>>> desktop, and rarely don't see it on my
>>>> laptop. I will investigate further but I think it is worth
>>>> including as a harmless patch.
>>>>
>>>> 2013-XX-XX Adam Domurad <adomurad at redhat.com>
>>>>
>>>> Ensure that PluginAppletviewer is resized in case of error.
>>>> This fixes most of the cases of the error splash screen
>>>> not appearing.
>>>> *
>>>> plugin/icedteanp/java/sun/applet/PluginAppletPanelFactory.java
>>>> (createPanel): Resize earlier, before erroring out.
>>>> * plugin/icedteanp/java/sun/applet/PluginAppletViewer.java
>>>> (PluginAppletViewer): Set size, remove fixme.
>>>>
>>>> Apologies for 'magic' patch,
>>>> -Adam
>>> Well, I'm, ok to give an try to this.
>>> Have you run at least some smaller reproducers run?
>>
>> Basic ones yes, and a few sites, not that it means much.
>> -Adam
>
> Fair enough:)
>>
>>>
>>>
>>> J.
>>
>
OK to push then ?
-Adam
More information about the distro-pkg-dev
mailing list