[rfc][icedtea-web] itw itself warning cleanup

[Omair Majid]

* Jiri Vanek <jvanek at redhat.com> [2013-12-13 07:50]:
> What do you think  about other warnings?
>  warning: [deprecation] >> Ref in sun.misc has been deprecated

What's the code causing this?

>  warning: [deprecation] >> toURL() in File has been deprecated
>  and proprietary api
> - there is hardly something to do....?-(

The replacement for File.toURL() is File.toURI().toURL(), which has a
few differences in how characters are escaped.

> But following should be fixed. I think that the _breaks_ should be
> added. But I'm not sure. It was added by Omair in 2011, do you
> remember who *reviewed* it?

No, the code is meant as written. The first 3 cases set which proxy to
return and end with a `break`. The following cases are not implemented,
so they fall through (and update the debug message to print) until
Proxy.NO_PROXY is returned.

>  But the TODO in comments make me  feel uncomfortable.

If the code is modified to fix the TODOs, the fall-through to NO_PROXY
will become incorrect. `break`s will need to be added at that point.

Thanks,
Omair