[rfc][icedtea-web] itw itself warning cleanup

[Jiri Vanek]

On 12/14/2013 07:36 AM, Omair Majid wrote:
> * Jiri Vanek<jvanek at redhat.com>  [2013-12-13 07:50]:
>> What do you think  about other warnings?
>>   warning: [deprecation]>>  Ref in sun.misc has been deprecated
>
> What's the code causing this?
>
>>   warning: [deprecation]>>  toURL() in File has been deprecated
>>   and proprietary api
>> - there is hardly something to do....?-(

netx/net/sourceforge/jnlp/runtime/JNLPClassLoader.java:import sun.misc.JarIndex;
netx/net/sourceforge/jnlp/runtime/JNLPClassLoader.java:                        // Non-generic code in sun.misc.JarIndex
netx/net/sourceforge/jnlp/security/CertsInfoPane.java:import sun.misc.HexDumpEncoder;
netx/net/sourceforge/jnlp/security/MoreInfoPane.java:                icon = new ImageIcon((new sun.misc.Launcher())
netx/net/sourceforge/jnlp/security/MoreInfoPane.java:                icon = new ImageIcon((new sun.misc.Launcher())
netx/net/sourceforge/jnlp/security/CertWarningPane.java:        ImageIcon icon = new ImageIcon((new sun.misc.Launcher())
netx/net/sourceforge/jnlp/security/UnsignedAppletTrustWarningPanel.java:        final ClassLoader appLoader = new sun.misc.Launcher().getClassLoader();
netx/net/sourceforge/jnlp/security/AccessWarningPane.java:        ImageIcon icon = new ImageIcon((new sun.misc.Launcher()).getClassLoader().getResource("net/sourceforge/jnlp/resources/question.png"));
netx/net/sourceforge/jnlp/security/NotAllSignedWarningPane.java:        ImageIcon icon = new ImageIcon((new sun.misc.Launcher()).getClassLoader().getResource("net/sourceforge/jnlp/resources/warning.png"));
netx/net/sourceforge/jnlp/PluginBridge.java:import sun.misc.BASE64Decoder;
plugin/icedteanp/java/sun/applet/PluginAppletViewer.java:import sun.misc.Ref;  (for     private synchronized Ref getCachedImageRef(URL url) {)


 From those the sun.misc.BASE64Decoder can be easily fixed in same way as Base64Encoder was - http://icedtea.classpath.org/hg/icedtea-web/rev/f1468696eda3  (i will do this as some another changeset)

>
> The replacement for File.toURL() is File.toURI().toURL(), which has a
> few differences in how characters are escaped.

Yes, I wrote it in first email:

"2) icedtea-web/netx/net/sourceforge/jnlp/cache/ResourceTracker.java:357: warning: [deprecation] toURL() in File has been deprecated
    icedtea-web/netx/net/sourceforge/jnlp/cache/CacheUtil.java:128: warning: [deprecation] toURL() in File has been deprecated
    icedtea-web/netx/net/sourceforge/jnlp/runtime/Boot.java:261: warning: [deprecation] toURL() in File has been deprecated


There have been a lot of work around cach x file x url escaping, and as main difference between file.tourl and file.touri.tourl is escaping, I rather left it. "

>
>> But following should be fixed. I think that the _breaks_ should be
>> added. But I'm not sure. It was added by Omair in 2011, do you
>> remember who *reviewed* it?
>
> No, the code is meant as written. The first 3 cases set which proxy to
> return and end with a `break`. The following cases are not implemented,
> so they fall through (and update the debug message to print) until
> Proxy.NO_PROXY is returned.

I was afraid of something like this. Thanx for clarification!
ps. the hg annotate added you to cc list O:)

>
>>   But the TODO in comments make me  feel uncomfortable.
>
> If the code is modified to fix the TODOs, the fall-through to NO_PROXY
> will become incorrect. `break`s will need to be added at that point.
>

ooook.



Thanx again for  clarification!
   J.