[rfc][icedtea-web] fixed CacheLRUWrapperTest

Jiri Vanek jvanek at redhat.com
Thu Dec 19 07:05:08 PST 2013


no, itw was not fixed :( just one test.. :)


-------- Original Message --------
Subject: [rfc][icedtea-web] fixed
Date: Thu, 19 Dec 2013 15:19:43 +0100
From: Jiri Vanek <jvanek at redhat.com>
To: IcedTea Distro List <distro-pkg-dev at openjdk.java.net>

Those two tests stared to fail recently, and it appeared they wer enot testing what they were
pretending to test.

They were pretending to test /tmp/cache_file, but in fact were testing the real cache file.

This patch is fixing it, by exposing a bit two variables with cached
JNLPRuntime.getConfiguration().getProperty(DeploymentConfiguration.KEY_USER_CACHE_DIR); value.

As one of the cached variables is opened properties file, then I'm not for fixing it better == do
not cache the value.

Also the test is now cleaning a biut after itself.

J.


and of course the unlucky
@@ -195,8 +195,6 @@
       }

       private String getIdForCacheFolder(String folder) {
-        System.out.println(folder);
-        System.out.println(cacheDir);
           int len = cacheDir.length();
           int index = folder.indexOf(File.separatorChar, len + 1);
           return folder.substring(len + 1, index);
so not belongs here as those two lines from previous "push" it will not be pusheed in final push.



-------------- next part --------------
A non-text attachment was scrubbed...
Name: fixedLruCacheUnitTest.diff
Type: text/x-patch
Size: 6206 bytes
Desc: not available
Url : http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20131219/5b01de85/fixedLruCacheUnitTest-0001.diff 


More information about the distro-pkg-dev mailing list