[rfc][icedtea-web] fixed

[Andrew Azores]

Could you make setters/getters for CacheLRUWrapper cacheDir and cacheOrder, rather than making the fields directly accessible? Just to safeguard against bugs where the LRU wrapper gets misused this way. eg make a getter that returns a copy of the cacheDir string, rather than making the cacheDir field directly accessible.

Minor formatting nits:
"private static  final String cacheIndexFileName ..." <- two spaces after static
"clw.cacheDir=System.getProperty ..." <- spaces around '=' please, looks inconsistent
And I assume the new try/finally blocks are indented but this is just not shown in the patch so it looks cleaner?

Why the change from Thread.sleep(1000) to 1010? Worried that after sleeping for 1000, the timestamp might still be the same? Since Thread.sleep isn't precise about how long the sleep actually lasts for, maybe a slightly larger "fudge factor" can be used if you're worried that 1000ms will be too short - because then 1010 also seems likely to come up short. 1050 or 1100 perhaps?

Thanks,

Andrew A

----- Original Message -----
From: "Jiri Vanek" <jvanek at redhat.com>
To: "IcedTea Distro List" <distro-pkg-dev at openjdk.java.net>
Sent: Thursday, December 19, 2013 9:19:43 AM
Subject: [rfc][icedtea-web] fixed

Those two tests stared to fail recently, and it appeared they wer enot testing what they were 
pretending to test.

They were pretending to test /tmp/cache_file, but in fact were testing the real cache file.

This patch is fixing it, by exposing a bit two variables with cached 
JNLPRuntime.getConfiguration().getProperty(DeploymentConfiguration.KEY_USER_CACHE_DIR); value.

As one of the cached variables is opened properties file, then I'm not for fixing it better == do 
not cache the value.

Also the test is now cleaning a biut after itself.

J.


and of course the unlucky
@@ -195,8 +195,6 @@
      }

      private String getIdForCacheFolder(String folder) {
-        System.out.println(folder);
-        System.out.println(cacheDir);
          int len = cacheDir.length();
          int index = folder.indexOf(File.separatorChar, len + 1);
          return folder.substring(len + 1, index);
so not belongs here as those two lines from previous "push" it will not be pusheed in final push.