[rfc][icedtea-web] a new reproducer LiveConnect "function parameters" tests

[Adam Domurad]

On 02/12/2013 07:32 AM, Jana Fabrikova wrote:
> Hi Adam,
>
> thank you for the review and particularly for the nice tip with 
> decodeURIComponent!
>
> I have modified the patch and am sending the new version,
> the "StringIntMixed" test is present, it is the third test from the 
> end (all the tests look a bit different with decodeURIComponent, but 
> the order is the same).
>
>>
>> Just a question on this comment, is there a mixed array of int and
>> String in this patch ? I can't seem to see one.
>>
>>  > +
>>  > +    @Test
>>  > +    @TestInBrowsers(testIn = { Browsers.all })
>>  > +    @NeedsDisplay
>>  > +    public void AppletJSToJFuncParam_StringIntMixed_Test() throws
>> Exception {
>>  > + jsToJavaFuncParamSpecialTest("StringIntMixedParam", "[test,
>> 123]");
>>  > +    }
>>  > +
>>  > +    @Test
>>  > +    @TestInBrowsers(testIn = { Browsers.all })
>>  > +    @NeedsDisplay
>>  > +    public void AppletJSToJFuncParam_DummyObjectArray_Test() throws
>> Exception {
>>  > + jsToJavaFuncParamSpecialTest("DummyObjectArrayParam",
>> "[Dummy1, Dummy2]");
>>  > +    }
>>  > +
>>  > +    @Test
>>  > +    @TestInBrowsers(testIn = { Browsers.all })
>>  > +    @NeedsDisplay
>>  > +    public void AppletJSToJFuncParam_JSObject_Test() throws 
>> Exception {
>>  > +        jsToJavaFuncParamSpecialTest("JSObjectParam", "100, red");
>>  > +    }
>>  > +
>>  > +}
>>
>> Otherwise it's a great improvement. Try and see if you can get rid of
>> the special arguments with the URI decoding tip, if not it isn't a huge
>> deal and can probably go in as-is.
>>
>> Happy hacking,
>> -Adam
>
> Cheers,
> Jana

Great, definitely nice and lean now :-) Good work!

OK for HEAD by me.
-Adam