[rfc][icedtea-web] fixinf of desktop icon behaviour

[Jiri Vanek]

On 12/31/2012 03:17 PM, Omair Majid wrote:
> On 12/29/2012 01:32 PM, Jiri Vanek wrote:
>> On 12/27/2012 07:04 PM, Omair Majid wrote:
>>> On 12/21/2012 11:38 AM, Adam Domurad wrote:
>>>> On 12/21/2012 11:05 AM, Jiri Vanek wrote:
>>>>> Hi! This is fix for
>>>>> http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=725 - JNLP
>>>>> applications will prompt for creating desktop shortcuts every time
>>>>> they are run
>>>>>
>>>>> When I have seen Omairs original patch it was too much complicated, So
>>>>> I want at least to try this one.
>>>>
>>>> Do you know why Omair used explicit locking? I couldn't quite figure
>>>> it out
>>>>
>>>
>>> My first patch kept a record of all desktop entries that icedtea-web
>>> created in a file. This meant that if a user deleted the desktop icon,
>>> icedtea-web wouldn't prompt for the creation of that icon again.
>>>
>>
>> I was thinking about it in vice-versa. If he had  already created icon,
>> and then he delted it. And some time later he launch application again,
>> I would expect he would like to be asked again.
>
> I don't have strong feelings about this either way. Some user testing
> might prove insightful.
>
>> However, when he will refuse to create an desktop icon then he should
>> not be asked again.. that is *probably* true, but I'm not so sure... And
>> to achieve this something like your previous approach is needed.
>
> This sounds sensible to me too.
>
>> So what do you think about combination of my and yours approach?
>
> Sounds fine to me.
>
> I think it would be best to get the behaviour that we are sure is needed
> (what your initial patch does) into icedtea-web, and then we can try and

Ok. So I will continue in patch Adam is reviewing. There is more and more ticks rising up:
please see the substitution of environment variables[1] and pointing to cachedFile/url[2]

> figure out what to do with the corner cases where the right thing to do
> is not as obvious.

Ok. My initial ideas are:
* enhance "allow desktop icon" dialogue with always and never buttons (right now there is just allow/no)
  - for allow the icon will be created - after [1] patch the user will not be asked again so long as 
desktop icon exists.
  - for no - icon will not be created, but user will be asked if he launches the url again.
    - no more actions for allow/no. The behaviour will be then as in [1] patch
  - always  - the icon will be created and in ITW properties will be  url marked as "create an icon 
if it do not exists", user will be no longer bothered.and icon will be always recreated.
  - never - the icon will NOT be created and in ITW properties will be  url marked as "do not ever 
create an icon". user will be never prompted again, and url desktop icon will never be recreated.

Items recorded by never/always however should be accessible via ITW-settings, But I will be to lazy 
to do so O:)


J.

[1] http://mail.openjdk.java.net/pipermail/distro-pkg-dev/2012-December/021265.html
[2] http://mail.openjdk.java.net/pipermail/distro-pkg-dev/2013-January/021277.html