[rfc] [icedtea-web] desktop icon is pointing to cache instead to real url

[Jiri Vanek]

On 01/02/2013 04:34 PM, Adam Domurad wrote:
> On 01/02/2013 10:20 AM, Jiri Vanek wrote:
>> Hi!
>> During digging in desktop subsystem of ITW i found that desktop icon is pointing to cache instead
>> to url. HAve anybody idea why??? Eg it will not survive -Xclearcache,..
>
> I think this is the correct behaviour -- AFAICS this would allow it to work offline while pointing
> to the URL would not.

I don't think so. To clarify myself:
My idea is that javaws should find the cached version by itself. To deduct it from url. And do not 
have the execution destination pointing to cahce itself :)

But ok, As Omair said, this is for now to  allow offline launching. So unless you two disagree 
somehow, I will postpone this patch until offline launching is fixed and working as expected.

>
>>
>> This simple patch should fix it to point to real url instead of cached version:
>>
>> diff -r a16da8b96a0f netx/net/sourceforge/jnlp/util/XDesktopEntry.java
>> --- a/netx/net/sourceforge/jnlp/util/XDesktopEntry.java    Mon Dec 24 13:58:31 2012 +0100
>> +++ b/netx/net/sourceforge/jnlp/util/XDesktopEntry.java    Wed Jan 02 16:17:53 2013 +0100
>> @@ -93,7 +93,7 @@
>>          }
>>
>>          //Shortcut executes the jnlp from cache and system preferred java..
>
> Just a note that this comment would need updating too
sure. Sorry.

>
>> - fileContents += "Exec=" + "javaws" + " \"" + cacheFile.getAbsolutePath() + "\"\n";
>> +        fileContents += "Exec=" + "javaws" + " \"" + file.getSourceLocation() + "\"\n";
>>
>>          return new StringReader(fileContents);
>

J.