[rfc][icedtea-web] Extract URL processing in TinyHttpdImpl

[Andrew Azores]

On 06/10/2013 03:39 PM, Adam Domurad wrote:
> Thanks for the refactoring!
>
> On 06/10/2013 12:00 PM, Andrew Azores wrote:
>> Changelog:
>> * tests/test-extensions/net/sourceforge/jnlp/TinyHttpdImpl.java:
>> extracted some lines out of run() into new method urlToFilePath()
>
> You should use list symbols you changed in the ChangeLog if its only a 
> few. Eg:
> * tests/test-extensions/net/sourceforge/jnlp/TinyHttpdImpl.java
> (run): Calls urlToFilePath
> (urlToFilePath): New, extract path resolution from (run)
>
Good to know :)
> Indentation should be fixed here, easy way is to just autoformat in 
> eclipse (make sure your formatting profile uses spaces only).
>
>> +
>> +        for (String url : filePathTestUrls) {
>> +            String newUrl = TinyHttpdImpl.urlToFilePath(url);
>> +            Assert.assertEquals(newUrl, URLDecoder.decode(newUrl, 
>> "UTF-8"));
>> +        }
>> +    }
>>
>>      @Test
>>      public void stripHttpPathParamTest() {
My Eclipse formatting should be set up correctly now, hopefully these 
patches have come out properly this time.
>
>
> Otherwise looks good, though.
>
> Thanks again!
> -Adam

Thanks,

Andrew A
-------------- next part --------------
A non-text attachment was scrubbed...
Name: fix.patch
Type: text/x-patch
Size: 2552 bytes
Desc: not available
Url : http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20130611/cbaed8ee/fix.patch 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: unit_test.patch
Type: text/x-patch
Size: 2161 bytes
Desc: not available
Url : http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20130611/cbaed8ee/unit_test.patch