[rfc][icedtea-web] Extract URL processing in TinyHttpdImpl

[Adam Domurad]

On 06/11/2013 09:24 AM, Andrew Azores wrote:
> On 06/10/2013 03:39 PM, Adam Domurad wrote:
>> Thanks for the refactoring!
>>
>> On 06/10/2013 12:00 PM, Andrew Azores wrote:
>>> Changelog:
>>> * tests/test-extensions/net/sourceforge/jnlp/TinyHttpdImpl.java:
>>> extracted some lines out of run() into new method urlToFilePath()
>>
>> You should use list symbols you changed in the ChangeLog if its only 
>> a few. Eg:
>> * tests/test-extensions/net/sourceforge/jnlp/TinyHttpdImpl.java
>> (run): Calls urlToFilePath
>> (urlToFilePath): New, extract path resolution from (run)
>>
> Good to know :)
>> Indentation should be fixed here, easy way is to just autoformat in 
>> eclipse (make sure your formatting profile uses spaces only).
>>
>>> +
>>> +        for (String url : filePathTestUrls) {
>>> +            String newUrl = TinyHttpdImpl.urlToFilePath(url);
>>> +            Assert.assertEquals(newUrl, URLDecoder.decode(newUrl, 
>>> "UTF-8"));
>>> +        }
>>> +    }
>>>
>>>      @Test
>>>      public void stripHttpPathParamTest() {
> My Eclipse formatting should be set up correctly now, hopefully these 
> patches have come out properly this time.
>>
>>
>> Otherwise looks good, though.
>>
>> Thanks again!
>> -Adam
>
> Thanks,
>
> Andrew A

Thanks Andrew! Looks good to me, I will commit this on your behalf.
-Adam