[rfc][icedtea-web] fixfor portalbank.no

[Adam Domurad]

On 05/03/2013 10:23 AM, Jiri Vanek wrote:
> On 05/02/2013 07:07 PM, Omair Majid wrote:
>> On 05/02/2013 05:44 AM, Jiri Vanek wrote:
>>> >              /* Fully consuming current request helps with
>>> connection re-use
>>> >               *
>>> Seehttp://docs.oracle.com/javase/1.5.0/docs/guide/net/http-keepalive.html
>>> */
>>> >-
>>> StreamUtils.consumeAndCloseInputStream(httpConnection.getInputStream());
>>> >+
>>> HttpUtils.consumeAndCloseConnectionSilently(httpConnection);
>> Just a nit: the CloseConnection in the name
>> consumeAndCloseConnectionSilently implies that we are calling
>> disconnect() or otherwise closing the HttpURLConnection, while we are
>> not doing that explicitly to reuse connections.
>>
>
> Ouch. I do not wont to rename it any more :(
On 05/03/2013 10:23 AM, Jiri Vanek wrote:> On 05/02/2013 07:07 PM, Omair 
Majid wrote:
>> On 05/02/2013 05:44 AM, Jiri Vanek wrote:
>>> >              /* Fully consuming current request helps with
>>> connection re-use
>>> >               *
>>> Seehttp://docs.oracle.com/javase/1.5.0/docs/guide/net/http-keepalive.html
>>> */
>>> >-
>>> StreamUtils.consumeAndCloseInputStream(httpConnection.getInputStream());
>>> >+
>>> HttpUtils.consumeAndCloseConnectionSilently(httpConnection);
>> Just a nit: the CloseConnection in the name
>> consumeAndCloseConnectionSilently implies that we are calling
>> disconnect() or otherwise closing the HttpURLConnection, while we are
>> not doing that explicitly to reuse connections.
>>
>
> Ouch. I do not wont to rename it any more :(

I would have to agree with Omair here. I overlooked this originally, but 
it's a good catch.
Happy hacking,
-Adam