[icedtea-web] resurrection of (output)console?

[Omair Majid]

* Jiri Vanek <jvanek at redhat.com> [2013-11-05 12:05]:
> On 11/05/2013 04:12 PM, Omair Majid wrote:
> >The documentation is for users. The code is self documenting, but I
> >don't think it's fair to expect users to read the code.
> 
> I did not meant in code :) I ment "on plugin startup" and "on javaws startup" :)

Sure, but there should be a way for a non-developer to know that these
options exist. 

> btw - thsi effort with console was rised by Tomas Hoger, who had some
> supicions about itw and selinux was blocking the stdout/err. So he was
> desperate for console.
> 
> So here  you may find another inspiration of user who may use it.

Thanks for pointing this out. We should summarize this somewhere and not
rely on bits of information sticking in someone's head.

> >* Jiri Vanek<jvanek at redhat.com>  [2013-11-05 08:03]:
> >>You are whipping me for somebody else code :) This was hg move JavaConsole.
> >
> >Just so we can both laugh at the joke, this is my code :D (And yes,
> >looking back at it, there's quite a few things I should have done
> >better).
>
> :DDD Is it?? Then my apologise!

Eh, why? If it's bad code, it's bad code. Doesn't really matter who
wrote it :)

> ps: My girlfriend is sending regards, as she she now how nice I'm
> speaking about your skills, and  now she red this  " whipping me for
> somebody else code /this is my code :D" exchange. Ad she really smiled
> :)

Please pass on my regards to her too. I am happy to hear I made someone
smile :)

> >Also, there's no whipping intended here....
> >
> sure:)

I want to apologize if I was rude here. I pointed out everything that I
thought could be better in the patch (including the bugs in code I had
written). I did not mean to blame anyone (least of all you) for it.

> >Please keep in mind that in mind that the main purpose of the Java
> >Console is to display System.out and System.err [1]. Additional
> 
> Yes, this I did not. I thought all should be here. But I will keep in
> mind and probably support some filtering.

There's a "deployment.trace" option that might be good enough as a
binary switch.

> +++ b/netx/net/sourceforge/jnlp/resources/Messages.properties	Tue Nov 05 18:11:10 2013 +0100

> +SPLASHmainL2 = Additional information may be available in the console or logs. Even more information can be provided if debugging is enabled

"Even more information is available if debugging is enabled"

> +++ b/netx/net/sourceforge/jnlp/util/logging/JavaConsole.java	Tue Nov 05 18:11:10 2013 +0100

> +    public static JButton getShowButton(final Component parent) {

This is a little subjective, but this button probably belongs elsewhere.

Please feel free to push after fixing the string (and moving the show
button to some place more appropriate)

Cheers,
Omair