[rfc][icedtea-web] allow access to jars' attributes from jnlpfile class

[Jiri Vanek]

On 11/08/2013 03:32 PM, Andrew Azores wrote:
> On 11/08/2013 07:24 AM, Jiri Vanek wrote:
>> Above fixed, also littl ebut improved (some logic moved from pluginBridge to jnlpfile)
>>

As this should go to 1.4 , please double check before aprove.

>>
>>
>> J.
>
> Few nits again:
>
> JNLPFile:
> - instead of named String constants APP_NAME etc., maybe use an enum here? If not, at least make them final, especially since they're public. IMO enum is better though.
> - #getTitle() - last return statement has a typo. "Unnown" should be "Unknown"
this was removed (fixOnFix:)
> - #getTitleFromManifest() - typo, "manifes" is missing its 't'. Maybe "Check with application vendor" rather than "Check vendor of application" ?
>
sure.

> ManifestAttributes:
> - #getApplicationName() uses APP_NAME named constant - why not for the other two similar calls? You just have a hardcoded string in those.
yes, this was error.
>
>
> Thanks,
>
> --
> Andrew A
>

ok, here it goes.

It appeared, that with "Application title was not found in manifest. Check with application vendor" forced warning, some unitittest become to verbose. However Ihave torubles to disable it. I will fix the verbosity as another changeset.

J.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: addedAccessToManifestsAttributesFromJnlpFile3.patch
Type: text/x-patch
Size: 29675 bytes
Desc: not available
Url : http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20131110/03cc496c/addedAccessToManifestsAttributesFromJnlpFile3-0001.patch