[rfc][icedtea-web] allow access to jars' attributes from jnlpfile class

[Andrew Azores]

On 11/10/2013 07:08 AM, Jiri Vanek wrote:
> On 11/08/2013 03:32 PM, Andrew Azores wrote:
>> On 11/08/2013 07:24 AM, Jiri Vanek wrote:
>>> Above fixed, also littl ebut improved (some logic moved from 
>>> pluginBridge to jnlpfile)
>>>
>
> As this should go to 1.4 , please double check before aprove.
>
>>>
>>>
>>> J.
>>
>> Few nits again:
>>
>> JNLPFile:
>> - instead of named String constants APP_NAME etc., maybe use an enum 
>> here? If not, at least make them final, especially since they're 
>> public. IMO enum is better though.
>> - #getTitle() - last return statement has a typo. "Unnown" should be 
>> "Unknown"
> this was removed (fixOnFix:)
>> - #getTitleFromManifest() - typo, "manifes" is missing its 't'. Maybe 
>> "Check with application vendor" rather than "Check vendor of 
>> application" ?
>>
> sure.
>
>> ManifestAttributes:
>> - #getApplicationName() uses APP_NAME named constant - why not for 
>> the other two similar calls? You just have a hardcoded string in those.
> yes, this was error.
>>
>>
>> Thanks,
>>
>> -- 
>> Andrew A
>>
>
> ok, here it goes.
>
> It appeared, that with "Application title was not found in manifest. 
> Check with application vendor" forced warning, some unitittest become 
> to verbose. However Ihave torubles to disable it. I will fix the 
> verbosity as another changeset.
>
> J.

Actual patch seems good, but in the ResourcesDescTest, why are there so 
many Manifests? Are manifest4 and manifest5 needed? Okay to push IMO 
after this.

Thanks,

-- 
Andrew A