[rfc][icedtea-web] removed recent check for multiple main jar

Andrew Azores aazores at redhat.com
Tue Nov 26 07:27:04 PST 2013

On 11/26/2013 08:25 AM, Jiri Vanek wrote:
> As Xerxes repoted today, new exception started to jump from multiple 
> jars (most of web) applets - RuntimeException("Multiple main JARs 
> specified, refusing to continue.")
> I was to rush to add this, and had just webStart in mind. There is 
> rotten issue/feature/correct behaviour in itw that all jars for 
> appelts are considered main.
> So my patch to javaws made all applets to stop work.

Sounds like the reviewer should have done some more testing too before 
approving... :(

> As for javaws discussion - this was already once fixed, and if strict 
> mode is on, then RuntimeException("Multiple main JARs specified, 
> refusing to continue.") is thrown from more correct location, 
> otherwise first mian jar is taken (see new testcase)
> This is causing some issues for  getting the attributes like 
> application-name or similar. Its hard to decide froim which jar they 
> should go. In case of applets they are searched in order as they are 
> written. So we can probably consider it as correct.
> For javaws they are first tried from first main jar, and then from 
> first jar where specified, again, in order as declared....  Not nice 
> but nothing better in mind :(

Yuck. Oh well, if it's the best that can be done, then it'll have to be 
good enough.

> There is one unrelated fix -
> + if (!result.toString().startsWith(base.toString()) && 
> !base.toString().startsWith(result.toString())){
> This line was causing strict to fail *always* but was *so* wrong that 
> I did not dare to remove the condition. The new testcase was leading 
> to this failure.
> J.

Well, I guess this is okay to go into head and bring us back to where we 
were. :)


Andrew A

More information about the distro-pkg-dev mailing list