[rfc][icedtea-web] removed recent check for multiple main jar

Jiri Vanek jvanek at redhat.com
Tue Nov 26 05:25:14 PST 2013


As Xerxes repoted today, new exception started to jump from multiple jars (most of web) applets - 
RuntimeException("Multiple main JARs specified, refusing to continue.")

I was to rush to add this, and had just webStart in mind. There is rotten issue/feature/correct 
behaviour in itw that all jars for appelts are considered main.
So my patch to javaws made all applets to stop work.

As for javaws discussion - this was already once fixed, and if strict mode is on, then 
RuntimeException("Multiple main JARs specified, refusing to continue.") is thrown from more correct 
location, otherwise first mian jar is taken (see new testcase)

This is causing some issues for  getting the attributes like application-name or similar. Its hard 
to decide froim which jar they should go. In case of applets they are searched in order as they are 
written. So we can probably consider it as correct.
For javaws they are first tried from first main jar, and then from first jar where specified, again, 
in order as declared....  Not nice but nothing better in mind :(

There is one unrelated fix -
+ if (!result.toString().startsWith(base.toString()) && 
!base.toString().startsWith(result.toString())){

This line was causing strict to fail *always* but was *so* wrong that I did not dare to remove the 
condition. The new testcase was leading to this failure.

J.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: removedFixToManifestedJar1TestCases-throwMultipleMaainJars.patch
Type: text/x-patch
Size: 4586 bytes
Desc: not available
Url : http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20131126/75a53913/removedFixToManifestedJar1TestCases-throwMultipleMaainJars.patch 


More information about the distro-pkg-dev mailing list