[rfc][icedtea-web] fixed another exception from get attributes

[Andrew Azores]

On 11/26/2013 08:38 AM, Jiri Vanek wrote:
> On 11/26/2013 01:35 PM, Xerxes Rånby wrote:
>> 2013-11-26 11:29, Jiri Vanek skrev:
>>> Reported today by Xerxes, test is longer then fix :)
>>> Also the page with it was added to 
>>> http://icedtea.classpath.org/wiki/IcedTea-Web-Tests - 
>>> http://joliclic.free.fr/html/object-tag/en/object-java.html
>>>
>>> Thanx for keeping en eye on head Xerxes!
>>>
>>> J.
>>>
>>
>> The NPE is fixed on my side as well with the patch attached.
>> Passed: net.sourceforge.jnlp.runtime.JNLPClassLoaderTest.tryNullManifest
>>
>> A review of the patch:
>>
>> diff -r 5cbe8b1de584 
>> netx/net/sourceforge/jnlp/runtime/JNLPClassLoader.java
>> --- a/netx/net/sourceforge/jnlp/runtime/JNLPClassLoader.java Tue Nov 
>> 26 11:05:25 2013 +0100
>> +++ b/netx/net/sourceforge/jnlp/runtime/JNLPClassLoader.java Tue Nov 
>> 26 11:25:00 2013 +0100
>> @@ -900,6 +900,11 @@
>>               JarFile mainJar = null;
>>               try {
>>                   mainJar = new JarFile(f);
>> +                Manifest manifest = mainJar.getManifest();
>> +                if (manifest == null || manifest.getMainAttributes() 
>> == null){
>> +                    //yes, jars without manifest exists
>> +                    return null;
>> +                }
>>                   attributeValue = mainJar.getManifest().
>>
>> How about using the already fetched manifest. here? ^
>>
>
> Sure. Fixed. Thanx for check!
>
>>
>> Thank you Jiri for the good object tag discussion in #openjdk at 
>> irc.oftc.net
>>
>> Cheers
>> Xerxes
>>
>

This looks good to me, okay for head.

Thanks,

-- 
Andrew A