[rfc][icedtea-web] refactored logging

[Jiri Vanek]

On 09/28/2013 01:52 AM, Omair Majid wrote:
> On 09/10/2013 04:19 PM, Jiri Vanek wrote:
>> This patch is introducing bottleneck for all stdout/err and
>> printstacktrace.
>
> Do you have any plans to replace PluginDebug as well?
>
> Thanks,
> Omair
>
I'm not sure if I replied correctly last time (I did not imho)

The pluginDebug.debug was included in refactoring patch:

public class PluginDebug {

     static final boolean DEBUG = JNLPRuntime.isPluginDebug();

     public static void debug(Object... messageChunks) {
         if (DEBUG) {
             if (messageChunks == null) {
                 messageChunks = new Object[] {null};
             }
             StringBuilder b = new StringBuilder();
             for (Object chunk : messageChunks) {
                 b.append(chunk);
             }
             OutputController.getLogger().log(OutputController.Level.ERROR_ALL, b.toString());
         }
     }
}

But I see I made an mistake. It should be

-    static final boolean DEBUG = JNLPRuntime.isPluginDebug();
+    static final boolean DEBUG = JNLPRuntime.isDebug();


Can I push?




The tasks which are now missing are:
  - do in C part the same (debug on/of by same way, file/streams(/system))
  - share file-log between c and java (My intention is  to pass filename in same way as pipes paths 
are sent)
  - implement the sytsem logger


I hope this answer is much better :)

J.