[rfc][icedtea-web] refactored logging

[Omair Majid]

* Jiri Vanek <jvanek at redhat.com> [2013-10-18 06:44]:
> I'm not sure if I replied correctly last time (I did not imho)
> 
> The pluginDebug.debug was included in refactoring patch:
> 
> public class PluginDebug {
> 
>     static final boolean DEBUG = JNLPRuntime.isPluginDebug();
> 
>     public static void debug(Object... messageChunks) {
>         if (DEBUG) {
>             if (messageChunks == null) {
>                 messageChunks = new Object[] {null};
>             }
>             StringBuilder b = new StringBuilder();
>             for (Object chunk : messageChunks) {
>                 b.append(chunk);
>             }
>             OutputController.getLogger().log(OutputController.Level.ERROR_ALL, b.toString());
>         }
>     }
> }
> 
> But I see I made an mistake. It should be
> 
> -    static final boolean DEBUG = JNLPRuntime.isPluginDebug();
> +    static final boolean DEBUG = JNLPRuntime.isDebug();
> 
> 
> Can I push?

Sure. Might as well remove JNLPRuntime.isPluginDebug() too, no?

Actually, out of curiosity, what's the reason for keeping
PluginDebug.debug() ?

> The tasks which are now missing are:
>  - do in C part the same (debug on/of by same way, file/streams(/system))
>  - share file-log between c and java (My intention is  to pass
> filename in same way as pipes paths are sent)
>  - implement the sytsem logger

One more: running 'make check' should not produce >2M of
output :)

> I hope this answer is much better :)

Not that the previous answer was bad, but this one is better :)

Cheers,
Omair