[rfc][icedtea-web] refactored logging
Jiri Vanek
jvanek at redhat.com
Mon Oct 21 06:54:42 PDT 2013
On 10/18/2013 10:26 PM, Omair Majid wrote:
> * Jiri Vanek <jvanek at redhat.com> [2013-10-18 06:44]:
>> I'm not sure if I replied correctly last time (I did not imho)
>>
...
>>
>> Can I push?
>
> Sure. Might as well remove JNLPRuntime.isPluginDebug() too, no?
Nope, there is logic. But I made it private.
>
> Actually, out of curiosity, what's the reason for keeping
> PluginDebug.debug() ?
lazines :) It would be needed to refactor (mostly manually or get dirty api in new logger) another
hundred of lines of code.
>
>> The tasks which are now missing are:
>> - do in C part the same (debug on/of by same way, file/streams(/system))
>> - share file-log between c and java (My intention is to pass
>> filename in same way as pipes paths are sent)
>> - implement the sytsem logger
>
> One more: running 'make check' should not produce >2M of
> output :)
hmm:(( I made some digging oi this, and I'm not able to reproduces.
Now -verbose, ICEDTEAPLUGIN_DEBUG, and deployment.log=true in
~/.config/icedtea-web/deployment.properties enable the same debug "level"
May you verify how output of make check is affected by them?
When I have no deployment.properties (or deployment.log=false), nor ICEDTEAPLUGIN_DEBUG nor -verbose
on comamndline (hardcoded) then I have normal, nice, clean ouput :(
J.
More information about the distro-pkg-dev
mailing list